Fix #548: :i? doesnt provide command description #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
reviewed
Jan 29, 2024
src/agent/index.ts
Outdated
| @@ -85,7 +85,7 @@ const commandHandlers = { | |||
| 'ii*': info.listImportsR2, | |||
| iij: info.listImportsJson, | |||
| il: [info.listModules, 'list libraries'], | |||
| 'il.': info.listModulesHere, | |||
| 'il.': [info.listModulesHere, 'list libraries of current offset'], | |||
There was a problem hiding this comment.
Would be good to define an interface for this commandHandlers object so that doesnt fail at runtime. Also if thats the case, there are many other commands that take the function name instead of an array. So im not sure if thats whats expected
|
Merging, but the ticket was not reported properly and it was not clear what was about to fix this, i have commented this in the other side too. i will do a proper fix to avoid having to document every single subcommand modifier which was the intention as its how things are in r2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.