Add symbols.unredact config variable #144
Conversation
`true` by default, it allows to retrieve the symbol name from the debug symbols (CoreSymbolication) when it’s “redacted” in apple’s dyld cache.
src/agent/config.js
Outdated
| if (typeof (val) === 'boolean') { | ||
| return true; | ||
| } | ||
| return ['true', 'false'].indexOf(val) !== -1; |
There was a problem hiding this comment.
what about return (/(true|false)/i).test(val); so its case insensitive. Also, we have the isTrue() helper below
src/agent/index.js
Outdated
| }) | ||
| .join('\n'); | ||
| } | ||
|
|
||
| function sanitizeString (str) { | ||
| const result = []; |
There was a problem hiding this comment.
what about using map/filter for this?
return str.split().map(_ => insaneSet.has(x)? c:'_').join('')
| if (config.getBoolean('symbols.unredact') && sym.name.indexOf('redacted') !== -1) { | ||
| const dbgSym = DebugSymbol.fromAddress(sym.address); | ||
| if (dbgSym !== null) { | ||
| sym.name = dbgSym.name; |
There was a problem hiding this comment.
uhm, when we find the symbol we dont need to continue searching , right? maybe good to use a for loop to break it here
There was a problem hiding this comment.
we're not searching here, it's just iterating over all the results of enumerateSymbols
src/agent/index.js
Outdated
| @@ -34,6 +34,7 @@ const allocPool = {}; | |||
| const pendingCmds = {}; | |||
| const pendingCmdSends = []; | |||
| let sendingCommand = false; | |||
| const insaneSet = new Set(['`', '$', '{', '}', '~', '|', ';', '#', '@', '&', '<', '>', ' ', '(', ')']); | |||
There was a problem hiding this comment.
a single string is probably faster imho. const specialChars = "`${}~|;#...".
and then use sspecialChars.indexOf(ch) !== -1
src/agent/config.js
Outdated
| @@ -8,7 +8,8 @@ const config = { | |||
| 'stalker.timeout': 5 * 60, | |||
| 'stalker.in': 'raw', | |||
| 'hook.backtrace': true, | |||
| 'hook.verbose': true | |||
| 'hook.verbose': true, | |||
| 'symbols.unredact': true | |||
There was a problem hiding this comment.
should be set to false outside iOS (and maybe macOS) too
trueby default, it allows to retrieve the symbol name from the debug symbols (CoreSymbolication) when it’s “redacted” in apple’s dyld cache.Also, while at it, added some sanitisation on flag names, to avoid accidental creation of garbage files and such.
Example: