JSON format checking improved

codeigniter4#2080 (...) And I thought the correct code was (strpos($value, '"') === 0 && strrpos($value, '"') === strlen($value) - 1 ) (...)
nowackipawel · Jun 29, 2019 · 987b705 · 987b705
1 parent cd97aba
commit 987b705
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/system/Entity.php b/system/Entity.php
@@ -588,7 +588,8 @@ private function castAsJson($value, bool $asArray = false)
 		$tmp = ! is_null($value) ? ($asArray ? [] : new \stdClass) : null;
 		if (function_exists('json_decode'))
 		{
-			if ((is_string($value) && (strpos($value, '[') === 0 || strpos($value, '{') === 0 || (strpos($value, '"') === 0 && strrpos($value, '"') === 0 ))) || is_numeric($value))
+			$strlen = is_strimg($value) ? strlen($value) : 0;
+			if (($strlen > 1 && is_string($value) && ((strpos($value, '[') === 0 && strrpos($value, ']') === $strlen - 1) || (strpos($value, '{') === 0 && strrpos($value, '}') === $strlen - 1) || (strpos($value, '"') === 0 && strrpos($value, '"') === $strlen - 1))) || is_numeric($value))
 			{
 				$tmp = json_decode($value, $asArray);