Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): In app editor fixes #7094

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

desiprisg
Copy link
Contributor

@desiprisg desiprisg commented Nov 20, 2024

What changed? Why was the change needed?

Screenshots

New previews:
Screenshot 2024-11-21 at 11 53 56 PM
Screenshot 2024-11-21 at 11 54 08 PM

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Nov 20, 2024

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 882ea63
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/673faf1b4678090008c96107
😎 Deploy Preview https://deploy-preview-7094--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djabarovgeorge
Copy link
Contributor

which change fixed the first issue, of updating the variable icon from { to {{?

@desiprisg
Copy link
Contributor Author

which change fixed the first issue, of updating the variable icon from { to {{?

No change yet. Needs to be added in figma first.

@desiprisg desiprisg changed the title fix(dashboard): Align body and actions with in-app subject preview fix(dashboard): In app editor fixes Nov 21, 2024
@desiprisg desiprisg force-pushed the nv-4829-apply-ui-fixes-to-in-app-step-editor branch from aee9e4d to b268349 Compare November 21, 2024 21:53
@desiprisg desiprisg force-pushed the nv-4829-apply-ui-fixes-to-in-app-step-editor branch from b268349 to 882ea63 Compare November 21, 2024 22:07
@desiprisg desiprisg merged commit 62ad1a1 into next Nov 21, 2024
25 checks passed
@desiprisg desiprisg deleted the nv-4829-apply-ui-fixes-to-in-app-step-editor branch November 21, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants