-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): In app editor fixes #7094
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
which change fixed the first issue, of updating the variable icon from { to {{? |
SokratisVidros
approved these changes
Nov 21, 2024
No change yet. Needs to be added in figma first. |
desiprisg
force-pushed
the
nv-4829-apply-ui-fixes-to-in-app-step-editor
branch
from
November 21, 2024 13:22
03b1979
to
b73adbc
Compare
desiprisg
force-pushed
the
nv-4829-apply-ui-fixes-to-in-app-step-editor
branch
from
November 21, 2024 13:23
b73adbc
to
7fff9dd
Compare
desiprisg
changed the title
fix(dashboard): Align body and actions with in-app subject preview
fix(dashboard): In app editor fixes
Nov 21, 2024
desiprisg
force-pushed
the
nv-4829-apply-ui-fixes-to-in-app-step-editor
branch
from
November 21, 2024 21:53
aee9e4d
to
b268349
Compare
desiprisg
force-pushed
the
nv-4829-apply-ui-fixes-to-in-app-step-editor
branch
from
November 21, 2024 22:07
b268349
to
882ea63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
New previews:
Expand for optional sections
Related enterprise PR
Special notes for your reviewer