fix(application-generic): Allow unauthorized certs for bridge url #6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
requested review from
djabarovgeorge
and removed request for
LetItRock
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rifont
reviewed
Oct 18, 2024
| // Test that the update button is enabled again when the form value changes | ||
| await senderName.fill('Novu edited'); | ||
| await expect(updateButton).toBeEnabled(); | ||
|
|
There was a problem hiding this comment.
Is this change intended? It seems unrelated to the PR title
rifont
reviewed
Oct 18, 2024
libs/application-generic/src/usecases/execute-bridge-request/execute-bridge-request.usecase.ts
Outdated
Show resolved
Hide resolved
rifont
approved these changes
Oct 18, 2024
SokratisVidros
force-pushed
the
allow_unauthorized_certs_for_bridge_url
branch
from
6ea4c79
to
060dac7
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
requested review from
scopsy and
merrcury
and removed request for
a team
…ment Reject self-signed and invalid certificates in Production environments but allow them in Development as it's common for developers to use self-signed certificates in local environments.
SokratisVidros
force-pushed
the
allow_unauthorized_certs_for_bridge_url
branch
from
060dac7
to
74cf782
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
|
rifont
reviewed
Oct 19, 2024
| * Reject self-signed and invalid certificates in Production environments but allow them in Development | ||
| * as it's common for developers to use self-signed certificates in local environments. | ||
| */ | ||
| rejectUnauthorized: true, |
There was a problem hiding this comment.
@SokratisVidros the new error response looks great! One thing though - you forgot to revert the change here to check Environement.name after testing
There was a problem hiding this comment.
😮💨 Fixed on next. Thanks for noticing. That's what happens if you are committing code in between Duplo gaming sessions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Reject self-signed and invalid certificates in Production environments but allow them in Development as it's common for developers to use self-signed certificates in local environments.
Screenshots