feat(dashboard): Create workflow sheet #6699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
4fcb704
to
367cdd5
Compare
@novu/client
@novu/framework
novu
@novu/headless
@novu/nest
@novu/js
@novu/nextjs
@novu/node
@novu/notification-center
@novu/react
@novu/providers
@novu/shared
@novu/react-native
@novu/stateless
commit: |
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
5 times, most recently
from
9db54e7
to
a592779
Compare
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
a592779
to
506c6f4
Compare
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
506c6f4
to
38c33ca
Compare
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
38c33ca
to
fbab06c
Compare
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
fbab06c
to
c1de3a0
Compare
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
c1de3a0
to
3e72524
Compare
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
3e72524
to
425aa41
Compare
SokratisVidros
approved these changes
Oct 17, 2024
BiswaViraj
reviewed
Oct 17, 2024
Comment on lines
+10
to
+11
| import { RiErrorWarningFill, RiInformationFill } from 'react-icons/ri'; | ||
| import { BsFillInfoCircleFill } from 'react-icons/bs'; |
There was a problem hiding this comment.
❓ question: What is our approach for icons for the dashboard?
I see we are also creating react svg files from figma.
There was a problem hiding this comment.
This was the closest I could find. I generally thought we were using remix icons, but it seems that it's not the case.
There was a problem hiding this comment.
we are also using icons like this by copying from the figma directly
There was a problem hiding this comment.
Yeah but some match icons in react-icons, so there's no need to do that. Do you think I should copy the svg in this case?
There was a problem hiding this comment.
No i think it's fine, was just curious about how we are using the icons in the new dashboard
There was a problem hiding this comment.
only these are the custom icons: https://www.figma.com/design/iOS9MnuJjLR7avdSIHemFy/novu-v3.0-Design-System-%E2%9A%A1%EF%B8%8F?node-id=125-263&node-type=text&m=dev
the rest are remix icons
BiswaViraj
reviewed
Oct 17, 2024
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
425aa41
to
5fbd1d9
Compare
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
5fbd1d9
to
677565a
Compare
desiprisg
force-pushed
the
nv-4316-build-the-create-workflow-drawer
branch
from
677565a
to
8778d77
Compare
BiswaViraj
approved these changes
Oct 18, 2024
LetItRock
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer