-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add api exception mapping #6601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatarco
force-pushed
the
add-api-exception-mapping
branch
from
October 1, 2024 12:28
90f4ca4
to
24f5b11
Compare
tatarco
commented
Oct 1, 2024
tatarco
force-pushed
the
add-api-exception-mapping
branch
from
October 2, 2024 07:55
ffac9dc
to
eddde60
Compare
tatarco
changed the title
feat: Add api exception mapping
feat(api): Add api exception mapping
Oct 2, 2024
Before this fix, the widget was hidden if the user did not set or cleared the Bridge URL. The same feature flag controlled the top level back button for the workflow page.
tatarco
force-pushed
the
add-api-exception-mapping
branch
from
October 7, 2024 13:08
9bb4178
to
1b90406
Compare
tatarco
requested review from
scopsy and
merrcury
and removed request for
a team
October 7, 2024 13:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
We are having issues caused by a very basic error handling in our nest.js app, causing 500 error to not be logged in a good way, the solution is described in the loom here
https://www.loom.com/share/e6d13666ce94441c9316e9f13bd94472?sid=17c07829-447c-40ac-a9bd-9e01279729ad
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer