Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): Com 229 update the in app preview component in the web app to #6600

Merged

Conversation

BiswaViraj
Copy link
Member

What changed? Why was the change needed?

  • created novu/js/internal package which exports the markdown parsing function
  • imported the markdown parsing function from novu/js/internal into the dashboard to support bold in-app previews

Screenshots

image

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@BiswaViraj BiswaViraj changed the title Com 229 update the in app preview component in the web app to feat(js):Com 229 update the in app preview component in the web app to Oct 1, 2024
@@ -0,0 +1,36 @@
export interface Token {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Token a standard terminology in the Markdown realm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems so. ref.

@SokratisVidros SokratisVidros changed the title feat(js):Com 229 update the in app preview component in the web app to feat(js): Com 229 update the in app preview component in the web app to Oct 1, 2024
Copy link

pkg-pr-new bot commented Oct 1, 2024

Open in Stackblitz

novu

pnpm add https://pkg.pr.new/novuhq/novu@6600

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6600

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6600

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6600

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6600

@novu/nest

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nest@6600

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6600

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6600

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6600

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6600

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6600

@novu/stateless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/stateless@6600

commit: a00f54a

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit a00f54a
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/66ffb53a743fa20008748df1
😎 Deploy Preview https://deploy-preview-6600--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BiswaViraj BiswaViraj merged commit f60aa5b into next Oct 4, 2024
37 of 39 checks passed
@BiswaViraj BiswaViraj deleted the com-229-update-the-in-app-preview-component-in-the-web-app-to branch October 4, 2024 10:12
tatarco pushed a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants