-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): Fixing chat missing in events interface #5661
Merged
rifont
merged 25 commits into
novuhq:next
from
ameensom:fixing-chat-missing-in-events-interface
Jun 12, 2024
Merged
Changes from 8 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4d3b878
adding chat to overrides interface
ameensom e837799
Merge branch 'novuhq:next' into next
ameensom 869b3f3
feat(providers): adding mobishastra sms provider
ameensom 5ce88a0
Merge branch 'next' into next
ameensom 7371a28
Merge branch 'next' into next
ameensom 39a9543
fix(node): remove code unrelated to fix
ameensom d30a74a
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom 9e8eb45
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom 8fd34b4
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom 0ecb06b
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom e3ba4b6
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom 5ed67d6
fix(node): Add missing 'chat' property to ITriggerOverrides interface
ameensom f338a85
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom 6c77bc9
fix(events): Add 'whatsapp' property to ITriggerOverrides interface
ameensom 2dc18ec
refactor(events): Update IWhatsappOverrides interface to use IWhatsap…
ameensom f37b0c1
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom 4f13ccc
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom 249258f
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom 54dab5e
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom d0dd4ac
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom d2836ba
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom d3fe9e4
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom 67c282b
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom d7f53fa
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom ee7f0e2
Merge branch 'next' into fixing-chat-missing-in-events-interface
ameensom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are seeking to introduce stronger typing across out SDKs. This fallback into
object
creates a weak typing forchat
.Can we follow a similar pattern as
email
below, creating anIChatOverrides
interface and listing the necessary properties to expose in a strongly typed way?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally agree,
i've pushed a minor change that adds the expected keys inside template object, however I think we need to add more types, hence we have media sending and interactive messages, it does have lots of variety in it, i'll try to add more soon,
Let me know if the last change is good so I can move on with the other message types