Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated the conventional comments script to include emoji #5361

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

LetItRock
Copy link
Contributor

What change does this PR introduce?

Fix to use emoji in the conventional comments script ;)

Why was this change needed?

Other information (Screenshots)

@LetItRock LetItRock self-assigned this Apr 4, 2024
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit ac1dc7d
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/660ed9e6716dca00085171b5
😎 Deploy Preview https://deploy-preview-5361--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LetItRock LetItRock force-pushed the chore-conventional-comments-emoji-fix branch from 40a91a7 to ac1dc7d Compare April 4, 2024 16:48
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit ac1dc7d
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/660ed9e63c741800091113bb
😎 Deploy Preview https://deploy-preview-5361--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@antonjoel82 antonjoel82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Great addition!

Comment on lines +45 to +54
const EMOJI = {
[LABEL.praise]: '\u{1F44F}',
[LABEL.note]: '\u{1F5D2}',
[LABEL.nitpick]: '\u{1F913}',
[LABEL.thought]: '\u{1F4AD}',
[LABEL.suggestion]: '\u{270F}',
[LABEL.question]: '\u{2753}',
[LABEL.chore]: '\u{2611}',
[LABEL.issue]: '\u{26A0}',
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: Nice work -- great use of ChatGPT!‏

@LetItRock LetItRock merged commit da98b1b into next Apr 4, 2024
28 checks passed
@LetItRock LetItRock deleted the chore-conventional-comments-emoji-fix branch April 4, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants