Add exponential backoff with jitter for the In-App Notification Center to re-establish WebSocket connections #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ainouzgali
approved these changes
Mar 20, 2024
SokratisVidros
approved these changes
Mar 20, 2024
djabarovgeorge
deleted the
nv-3207-add-exponential-backoff-with-jitter-for-the-in-app-notification-center
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
During our most recent incident we observed that the In-app notification center was constantly tring to reconnect to the websocket service and creating a thundering herd on our websocket system.
novu/packages/application-generic/src/resilience/delay.ts
Line 8 in 4b9b818
Why was this change needed?
This will prevent our system from being overloaded if a network failure or a upgrade happens.
Other information (Screenshots)