Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NV-3561 | Component Audit #5297

Merged
merged 10 commits into from
Mar 14, 2024
Merged

NV-3561 | Component Audit #5297

merged 10 commits into from
Mar 14, 2024

Conversation

antonjoel82
Copy link
Contributor

@antonjoel82 antonjoel82 commented Mar 12, 2024

What change does this PR introduce?

Why was this change needed?

  • We want to assess what components from Mantine and our Design System are currently used directly in web and how
  • Part of NV-3561

Other information (Screenshots)

Sample output:
scan.grouped.json

You can also view the output as an [ugly] sortable table in Storybook:

Screenshot 2024-03-13 at 5 22 25 PM

To do so:

  1. Check out this branch
  2. Call pnpm audit-components in your terminal (in the design-system directory)
  3. Run Storybook, and navigate to ComponentAudit

Copy link

linear bot commented Mar 12, 2024

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit e9d5119
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/65f09744b6391f00084dde84
😎 Deploy Preview https://deploy-preview-5297--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 277edcf
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/65f356a9d8c15b0008a7445e
😎 Deploy Preview https://deploy-preview-5297--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antonjoel82 antonjoel82 marked this pull request as ready for review March 13, 2024 05:45
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job! I really like the table with sorting option! 🙌
left you a few small suggestions ;)

apps/web/src/components/scan.json Outdated Show resolved Hide resolved
apps/web/package.json Show resolved Hide resolved
libs/design-system/react-scanner.config.js Show resolved Hide resolved
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@antonjoel82 antonjoel82 merged commit 0130504 into next Mar 14, 2024
29 of 30 checks passed
@antonjoel82 antonjoel82 deleted the component-audit branch March 14, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants