Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gupshup request #5258

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Conversation

RahulDutta007
Copy link
Contributor

What change does this PR introduce?

  1. Remove httpsAgent in axios

Why was this change needed?

Other information (Screenshots)

Copy link

netlify bot commented Mar 5, 2024

👷 Deploy request for dev-web-novu pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f30b127

Comment on lines 7 to 8
import { Agent } from 'https';
import crypto from 'crypto';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { Agent } from 'https';
import crypto from 'crypto';

Please remove these unused imports.

Copy link
Member

@BiswaViraj BiswaViraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add the following to this file
  moduleNameMapper: {
    axios: 'axios/dist/node/axios.cjs',
  },
  1. on the root run pnpm install to update the pnpm.lock file.

Copy link
Member

@BiswaViraj BiswaViraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • To fix the spell check pipeline error, please add userid to this file
  • Also, fix the prettier issue in the gupshup.provider.ts file

@BiswaViraj BiswaViraj merged commit a6a61c1 into novuhq:next Mar 7, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants