Add Staging Web Pipeline #4108
Add Staging Web Pipeline #4108
Conversation
| # This workflow contains a single job called "build" | ||
| deploy_web: | ||
| needs: test_web | ||
| environment: Development |
There was a problem hiding this comment.
No, because it is the same as the dev env but with production specs.
| REACT_APP_SENTRY_DSN: https://[email protected]/4505829158158336 | ||
| REACT_APP_ENVIRONMENT: dev | ||
| REACT_APP_MAIL_SERVER_DOMAIN: staging.inbound-mail.novu.co | ||
| REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID: ${{ secrets.DEV_LAUNCH_DARKLY_CLIENT_SIDE_ID }} |
There was a problem hiding this comment.
We need to add a secret called STAGING_LAUNCH_DARKLY_CLIENT_SIDE_ID.
There was a problem hiding this comment.
Not at this time, the system is set up with the same variables as dev.
There was a problem hiding this comment.
I'd recommend not to do that as Launch Darkly provides the extra environment and we won't face the situations of someone touching the Dev env FF configuration and affecting staging, that as far as I remember we meant to have the closest situation as production for load testing and reliability testing. If I missed some of the nuances of the goal of Staging and it is meant to be a replica of Dev, we can go the way you suggest it. 👍🏻
Co-authored-by: Pablo Fernández <[email protected]>
Co-authored-by: Pablo Fernández <[email protected]>
This Pull Request adds a new pipeline to run and update novu's staging deployment for web.
Updates the same way as dev.