Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 2690 add identifier field to layouts scheme #3956

Merged

Conversation

ainouzgali
Copy link
Contributor

@ainouzgali ainouzgali commented Aug 13, 2023

What change does this PR introduce?

Add layout identifier to scheme and types.
Add to layout screens.
Add to sdk.

Will add migration script in a separate PR.

Why was this change needed?

Other information (Screenshots)

Screen Shot 2023-08-13 at 15 30 47 Screen Shot 2023-08-13 at 15 31 09

@linear
Copy link

linear bot commented Aug 13, 2023

NV-2690 Add identifier field to Layouts - scheme,api, migration

  • add identifier to the layout scheme.
  • add field accordingly to create + update + promote layout usecases.
  • add identifier field to UI - to the layouts table and to the layout editor.
  • add migration script for existing layouts
  • make necessary changes to node sdk
  • cover the functionality with tests
  • add section in docs

@ainouzgali ainouzgali marked this pull request as draft August 13, 2023 10:49
@ainouzgali ainouzgali marked this pull request as ready for review August 13, 2023 12:32
@ainouzgali ainouzgali self-assigned this Aug 13, 2023
@ainouzgali ainouzgali changed the title Nv 2690 add identifier field to layouts scheme + api migration Nv 2690 add identifier field to layouts scheme Aug 13, 2023
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 🎉 you always remember about everything! 💅

@ainouzgali ainouzgali added this pull request to the merge queue Aug 15, 2023
Merged via the queue into next with commit 59e54a8 Aug 15, 2023
28 of 31 checks passed
@ainouzgali ainouzgali deleted the nv-2690-add-identifier-field-to-layouts-schemeapi-migration branch August 15, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants