Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies with security issues #3901

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Aug 2, 2023

What change does this PR introduce?

Fixing some sub dependencies critical vulnerabilities.

Why was this change needed?

Other information (Screenshots)

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we still have some failing tests, or are they redundant?

@@ -84,7 +84,7 @@
"shortid": "^2.2.16",
"slugify": "^1.4.6",
"swagger-ui-express": "^4.4.0",
"twilio": "^3.72.0",
"twilio": "^4.14.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if the legacy sms service still exist, and if this dep even needed any more

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find usage of it, so probably not needed any more

@scopsy
Copy link
Contributor Author

scopsy commented Aug 2, 2023

@djabarovgeorge Yes, it's an unrelated error here

@scopsy scopsy merged commit 8769eb7 into next Aug 2, 2023
33 of 34 checks passed
@scopsy scopsy deleted the security-fixes branch August 2, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants