NV 2613 - Tenant Page Pagination #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
changed the title
djabarovgeorge
commented
Jul 26, 2023
|
|
||
| export class PaginatedResponseDto<T> { | ||
| export class PaginatedResponseDto<T> implements IPaginatedResponseDto<T> { |
There was a problem hiding this comment.
added new Shared IPaginatedResponseDto as an interface for the API DTO
djabarovgeorge
commented
Jul 26, 2023
| export function getTenants() { | ||
| return api.get('/v1/tenants'); | ||
| export function getTenants({ page = 0, limit = 10 } = {}) { | ||
| return api.getFullResponse('/v1/tenants', { page, limit }); |
There was a problem hiding this comment.
changed to get the hasMore and other pagination data.
djabarovgeorge
commented
Jul 26, 2023
There was a problem hiding this comment.
refactored to get the full response of the pagination and return from the hook.
djabarovgeorge
commented
Jul 26, 2023
| page, | ||
| limit, | ||
| }: { | ||
| options?: UseQueryOptions<IPaginatedResponseDto<ITenantEntity>, any>; |
There was a problem hiding this comment.
This is the place where i wanted to reuse the IPaginatedResponseDto interface.
djabarovgeorge
commented
Jul 26, 2023
Comment on lines
+42
to
+48
| pagination={{ | ||
| pageSize: pageSize, | ||
| current: page, | ||
| hasMore, | ||
| minimalPagination: true, | ||
| onPageChange: handleTableChange, | ||
| }} |
There was a problem hiding this comment.
added the pagination prop data.
djabarovgeorge
commented
Jul 26, 2023
libs/shared/src/dto/shared/shared.ts
Outdated
There was a problem hiding this comment.
new interface that i used in the useTenant hook and API DTO
…ge-pagination # Conflicts: # apps/web/src/pages/tenants/components/list/TenantsList.tsx
Base automatically changed from
NV-2612-tenant-page-empty-state
to
stacked-tenants-support
July 26, 2023 15:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Created the same pagination we have on the subscriber list page in order to reuse existing components.
Why was this change needed?
in order to check long lists of tenants.
Other information (Screenshots)
https://www.loom.com/share/f8e823495fe34c2d9fa542da79b60f0f