Nv 2612 - Tenant Page Empty State #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainouzgali
approved these changes
Jul 26, 2023
| @@ -23,9 +26,12 @@ export const TenantsList = ({ onAddTenantClick }: { onAddTenantClick: React.Mous | |||
| <Container fluid sx={{ padding: '0 30px 8px 30px' }}> | |||
| <Toolbar onAddTenantClick={onAddTenantClick} tenantLoading={tenantLoading} /> | |||
| </Container> | |||
| <When truthy={hasTenants || isLoading}> | |||
| <When truthy={loadingPhase}> | |||
There was a problem hiding this comment.
Just my opinion - your choice. I feel its easier to read when the conditions are here if they are not complex.
There was a problem hiding this comment.
for me, one boolean is more readable as long as it is chosen right. 🙃
apps/web/src/pages/tenants/components/list/TenantsListNoData.tsx
Outdated
Show resolved
Hide resolved
| <NoDataHolder data-test-id="no-integrations-placeholder"> | ||
| <Buildings style={{ fill: colors.B30, width: '50px', height: '45px', margin: '30px' }} /> | ||
| <NoDataText>Add the first tenant for the</NoDataText> | ||
| <NoDataText>development environment</NoDataText> |
There was a problem hiding this comment.
Notice that we need to be dynamic about the environment
There was a problem hiding this comment.
Oh really? I thought about it as a general 'development' tag, thanks for bringing it up I will update it!
…ge-empty-state # Conflicts: # apps/web/src/pages/tenants/components/list/TenantsList.tsx
Base automatically changed from
NV-2611-initial-tenants-page-ui
to
stacked-tenants-support
July 26, 2023 13:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Display an empty state when no tenants are found