-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user agent header #111
Conversation
@Cliftonz Can you please review? |
@mayorJAY Please review |
This implementation would give us the name and version of the client app instead of the info of this SDK. We need to revert and revisit the implementation @Cliftonz @unicodeveloper @VishalMCF |
@mayorJAY @Cliftonz @unicodeveloper I was thinking of an approach where I hardcode the version in the RetryHandlerClass. Name as you said can be hardcoded. I can write a test function that always checks if the version is the same as what we have in the pom.xml file. What do you say? That way don't have to risk reading the file during runtime. |
I don't think we should hardcode the version, that would mean updating the header every time there is a version change. If we modify the code based on my suggestions, we'd get what we need |
@mayorJAY cool, I will raise a new PR as per your suggestions |
resolves #104