This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Update internals #229
Merged
Update internals #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Available as snapshot build here: https://bintray.com/novoda/snapshots/bintray-release/SNAPSHOT-6 |
This was referenced Oct 7, 2018
Closed
StefMa
added a commit
to StefMa/UseKase
that referenced
this pull request
Jun 17, 2019
Case we are falling into novoda/bintray-release#229
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back we have faced an issue while trying to use this plugin to release a project using a recent version of Gradle (4.9+). After a quick look we thought the problem was on the JFrog Gradle plugin that we apply under the hood, but further investigation has confirmed that the issue is not present in recent versions of that plugin (1.8.1+). I then decided to go ahead and make this plugin compile against a more recent version of the JFrog one, but while testing this implementation (using composite builds) I faced an interesting issue.
The recent implementation of the JFrog plugin is registering a custom
BuildAdapterto configure the upload tasks lazily, using the values collected in the extension after all the projects are fully configured and are ready to populate the task graph. Unfortunately we were applying that plugin after the buildscript of the project is run, and it seems at that point is too late for the JFrog plugin to register its own build listener, therefore the upload tasks were not including all the properties specified in the extension.The fix is as easy as applying the JFrog plugin outside the
afterEvaluate {}.