This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Remove deprecated properties #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
approved these changes
Feb 7, 2018
|
Why do we need to wait for |
|
Okay, then merge it ☺
…On Feb 7, 2018 3:03 PM, "Said Tahsin Dane" ***@***.***> wrote:
Why do we need to wait for desc discussion? This PR seems to be fine to
me. Amending the mandatory check to make desc optional can be another PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJwYe6GwuZ4c6OPzmd_KZ2lmWDlWStvwks5tSa1GgaJpZM4R8wLK>
.
|
|
Wohooo |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190
Please don't merge until the description topic is resolved (see discussion in #190)