This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
give quicker feedback when setup incorrect #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
reviewed
Feb 5, 2018
| } | ||
| if (extensionError) { | ||
| String prefix = "Have you created the publish closure? " | ||
| throw new IllegalStateException(prefix + extensionError) |
There was a problem hiding this comment.
Are they all mandatory? I was thinking the description can be optional.
There was a problem hiding this comment.
yes all mandatory
description is mandatory https://github.com/novoda/bintray-release/blob/master/core/src/main/groovy/com/novoda/gradle/release/PublishExtension.groovy#L31
|
This fixes #118 right? |
|
yeah it will give better feedback in that error case |
mr-archano
approved these changes
Feb 5, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using on a pet project this weekend and wanted to sync once I added the dependency (but not written the closure yet). You get a cryptic error message like this:
So now if you don't have the closure, ie:
You get this error message:
Also added a change of error message for each missing individual required field of the closure.
ArtifactId missing:
gives:
The readme says
I Have not tested this in a kotlin prj :-)