This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Fix asynchronously added variants #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`all` should be used because variants may not be available at that time when `.forEach` is call. `all` will also be called for each variant which will added later. This means here is a race condition on some machines not adding the required tasks. see StefMa/AndroidArtifacts#9 From the documentation: https://docs.gradle.org/current/javadoc/org/gradle/api/DomainObjectCollection.html#all(groovy.lang.Closure) Executes the given action against all objects in this collection, and any objects subsequently added to this collection. "subsequently added" variants where ignored until now. fixes #96
|
Can one of the admins review this PR? |
|
ok to test |
|
Can a admin look why it's hanging?! |
|
ok to test |
|
yeah not really sure what's going on here
there's no queued builds on the CI 🤔 |
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allshould be used because variants may not be available at that time when.forEachis call.allwill also be called for each variant which will added later. This means here is a race condition on some machines not adding the required tasks.see StefMa/AndroidArtifacts#9
From the documentation:
https://docs.gradle.org/current/javadoc/org/gradle/api/DomainObjectCollection.html#all(groovy.lang.Closure)
Executes the given action against all objects in this collection, and any objects subsequently added to this collection.
"subsequently added" variants where ignored until now.
fixes #96