Fix byte/string conversion for Python 3. #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions throw TypeError exceptions if the parameters are already encoded/decoded. This can be avoided by type checking before attempting to encode/decode the parameters.
|
Figured out a simple solution: 1c39c7f The problem was really the initializing of b and c to normal strings. Just wrapping those in s2b() (and doing b2s on the accept value) fixes the issue. Thanks for reporting it. Even though I didn't go with your solution, seeing your solution helped me understand what was going on and create a fix faster so thanks for your effort. |
|
That looks much better. Thanks for fixing this issue! |
ncarrier
pushed a commit
to ncarrier/carino-packages-websockify
that referenced
this pull request
Mar 21, 2015
Simpler fix for this issue: novnc/websockify#9 Use consistent string/byte type for HyBi decode with numpy.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3's handling of bytes and strings caused the
Sec-WebSocket-Acceptheader to be wrapped inb'...', e.g. likeSec-WebSocket-Accept: b'qqPS3vItJSiRDxlSVrmaSmAi+MQ='as well as throwing aTypeErrorat line 315. These issues seem to be resolved by using thes2b/b2sfunctions to convert bytes/strings correctly. I'm able to run the tests successfully with both Python 2.7.2 and Python 3.2.2 after applying this patch.