Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to token #1021

Closed
wants to merge 2 commits into from
Closed

Add support to token #1021

wants to merge 2 commits into from

Conversation

linnil1
Copy link

@linnil1 linnil1 commented Feb 18, 2018

Hi.
I found that noVNC can redirect to any machine by using token with websockify. (wiki)

However, it doesn't work on recent version.
After reading code in app/ui.js, I found that path didn't include query section in URL.
So, just add it easily by directly add document.location.search

Also, the path is always point to ws://ip:port/websocky, which make bug when I deploy it, such as I add prefixStrip in the path like 127.0.0.1:8080/mypath/vnc.html.
The solution is to add window.location.pathname in path.

@CendioOssman
Copy link
Member

noVNC has the setting path that allows you to handle both of these things. E.g. http://example.com/mypath/vnc.html?path=%2Fmypath%2Fwebsockify%3Ftoken%3Dabc123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants