Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I found that noVNC can redirect to any machine by using token with websockify. (wiki)
However, it doesn't work on recent version.
After reading code in
app/ui.js
, I found thatpath
didn't include query section in URL.So, just add it easily by directly add
document.location.search
Also, the path is always point to
ws://ip:port/websocky
, which make bug when I deploy it, such as I add prefixStrip in the path like127.0.0.1:8080/mypath/vnc.html
.The solution is to add
window.location.pathname
in path.