fix: sign raw bytes #1332
Merged
fix: sign raw bytes #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montekki
reviewed
Oct 3, 2022
Comment on lines
+71
to
+75
| SignContent::Message(_) => match signature { | ||
| MultiSignature::Sr25519(a) => hex::encode(a), | ||
| MultiSignature::Ed25519(a) => hex::encode(a), | ||
| MultiSignature::Ecdsa(a) => hex::encode(a), | ||
| }, |
There was a problem hiding this comment.
I don't think that this is right
There was a problem hiding this comment.
Is it conceptually wrong, or is there a better way to write it? I struggle to find another solution.
There was a problem hiding this comment.
- I think that it is not a good pattern to turn a return type from
MultiSignaturetoString - Are you sure that this should be just the bare signature that is returned, not
MultiSignature? How the users are going to tell the difference between different signature schemes? In case of a transactionMultiSignatureis returned
montekki
approved these changes
Oct 6, 2022
This was referenced Oct 6, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing #1014, #997
Scope
Expect messages to be wraped in
<Bytes>...</Bytes>. It works like that in polkadotjs extension and StyloScreenshots
Signing up to https://polkadot.polkassembly.io/
