[FIX] formio : Formio.js version updates in Windows environments are not available #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strange, the .ids here must be removed to upgrade to v14.
environments are not available
added 2 commits
November 30, 2020 10:58
bobslee
reviewed
Dec 15, 2020
| if response.status_code == 200: | ||
| with open(tar_path, 'wb') as f: | ||
| f.write(response.raw.read()) | ||
| tar = tarfile.open(tar_path) | ||
| tar.extractall('/tmp', members=self._tar_extract_members(tar)) | ||
| if sys.platform == 'win32': | ||
| tar.extractall('%s' % static_path, members=self._tar_extract_members(tar)) |
There was a problem hiding this comment.
@niulinlnc no need for string templating (%s) right?
bobslee
added a commit
that referenced
this pull request
Dec 15, 2020
…s environments are not available) PR #92
bobslee
added a commit
that referenced
this pull request
Dec 15, 2020
…s environments are not available) PR #92
bobslee
added a commit
that referenced
this pull request
Dec 15, 2020
…s environments are not available) PR #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix formio.js version updates in Windows environments are not available.
Fix reloading error.