Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of http client gem is about 5 years ago. They are still shipping an embedded certificate trust store. We recently bumped into issues with this, as a cert renewed but it was no longer validated by http_client, but any other sane HTTP library would use the OS certs and could actually validate this.
This MR moves away from http_client gem and adapts Faraday and middleware. I understand this is a breaking change as the class passed in the
http_config
block is now aFaraday::Connection
rather than aHTTPClient
.