🚨 [security] Update express 4.15.2 → 4.21.1 (minor)

[depfu]

---

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

---

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ express (4.15.2 → 4.21.1) · Repo · Changelog

Security Advisories 🚨

🚨 express vulnerable to XSS via response.redirect()

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

1. The attacker MUST control the input to response.redirect()
2. express MUST NOT redirect before the template appears
3. the browser MUST NOT complete redirection before:
4. the user MUST click on the link in the template

🚨 Express.js Open Redirect in malformed URLs

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

0867302
0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

#5539
koajs/koa#1800
https://expressjs.com/en/4x/api.html#res.location

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ content-disposition (indirect, 0.5.2 → 0.5.4) · Repo · Changelog

Release Notes

0.5.4

• deps: [email protected]

0.5.3

• Use safe-buffer for improved Buffer API

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 73 commits:

• 0.5.4
• build: [email protected]
• build: [email protected]
• tests: fix deep equal checking
• build: support Node.js 17.x
• deps: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: support Node.js 16.x
• build: support Node.js 15.x
• build: [email protected]
• build: [email protected]
• build: support Node.js 14.x
• build: support Node.js 13.x
• build: [email protected]
• build: [email protected]
• lint: apply standard 13
• build: use GitHub Actions instead of Travis CI
• docs: fix typo in comment
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: support Node.js 12.x
• build: support Node.js 11.x
• 0.5.3
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: restructure Travis CI build steps
• lint: apply standard 12 style
• tests: replace deprecated assert.deepEqual with deep-equal
• build: [email protected]
• build: [email protected]
• tests: use strict equality
• build: support Node.js 10.x
• build: support Node.js 9.x
• build: [email protected]
• deps: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: use yaml eslint configuration
• docs: expand jsdoc on constructor
• lint: apply standard 11 style
• Use safe-buffer for improved Buffer API
• build: [email protected]
• build: [email protected]
• build: support Node.js 8.x
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: use precise dist on Travis CI
• lint: use standard style in readme
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: set package author
• docs: update copyright year
• docs: use default shields badge style
• docs: update jsdoc comments
• build: [email protected]
• build: [email protected]
• lint: remove unreachable branch

↗️ finalhandler (indirect, 1.0.6 → 1.3.1) · Repo · Changelog

Release Notes

1.2.1 (from changelog)

• Gracefully handle when handling an error and socket is null

1.2.0

• Remove set content headers that break response
• deps: [email protected]
• deps: [email protected]
  • Rename 425 Unordered Collection to standard 425 Too Early

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ forwarded (indirect, 0.1.2 → 0.2.0) · Repo · Changelog

Release Notes

0.2.0

• Use req.socket over deprecated req.connection

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ fresh (indirect, 0.5.0 → 0.5.2) · Repo · Changelog

Security Advisories 🚨

🚨 Regular Expression Denial of Service in fresh

Affected versions of fresh are vulnerable to regular expression denial of service when parsing specially crafted user input.

Recommendation

Update to version 0.5.2 or later.

Release Notes

0.5.2 (from changelog)

• Fix regression matching multiple ETags in If-None-Match
• perf: improve If-None-Match token parsing

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 23 commits:

• 0.5.2
• build: [email protected]
• build: [email protected]
• perf: improve If-None-Match token parsing
• Fix regression matching multiple ETags in If-None-Match
• 0.5.1
• perf: improve ETag match loop
• Fix handling of modified headers with invalid dates
• bench: add simple benchmarks
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: support Node.js 8.x
• build: [email protected]
• lint: apply standard 10 style
• build: [email protected]
• build: [email protected]
• build: use precise dist on Travis CI
• lint: use standard style in readme
• build: [email protected]
• build: [email protected]
• build: [email protected]
• build: [email protected]

↗️ ipaddr.js (indirect, 1.4.0 → 1.9.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 38 commits:

• Update version to 1.9.1
• Include LICENSE file in published package
• Update TypeScript definitions.
• Bump version.
• Update compiled files.
• Add IPv6.toRFC5952String.
• Deprecate non-compliant functions
• Add IPv6.toFixedLengthString.
• Return RFC 5952 compliant string
• Bump version.
• Update Typescript range definitions in include 'unicast'.
• Bump version.
• CIDR array response reversed to properly deliminated string
• correct typescript definition for subnetMatch
• Fix validation of IPv4 four-part decimals containing individual zeroes
• Bump version.
• Add support for IPv4 trailing and leading zeros
• Reduced npm package size by excluding tests, bower and CI files
• Bump version.
• add typescript definition file
• Bump version.
• Clarify Cakefile task names (again).
• Clarify Cakefile task names.
• Merge branch 'fix_for_84' of https://github.com/jamesmgreene/ipaddr.js
• Bump version.
• Fix main to resolve to existing file
• Simplified the `IPv6.prototype.toString` method
• Bump version.
• Fix parsing when zone index contains uppercase letters
• Bump version.
• Fix zoneIndex parsing for IPv4-mapped IPv6 addresses
• Bump version.
• Allow `ipaddr.IPv4.subnetMaskFromPrefixLength(32)`
• Add `IPv4.prototype.toNormalizedString` for symmetry with the IPv6 method
• Fix a minor bug in `subnetMatch` logic
• Add IPv6 zone index support
• add IPv6 prefixLengthFromSubnetMask
• Accept mixed IPv4/IPv6 range lists in ipaddr.subnetMatch.

↗️ path-to-regexp (indirect, 0.1.7 → 0.1.10) · Repo · Changelog

Security Advisories 🚨

🚨 path-to-regexp outputs backtracking regular expressions

Impact

A bad regular expression is generated any time you have two parameters within a single segment, separated by something that is not a period (.). For example, /:a-:b.

Patches

For users of 0.1, upgrade to 0.1.10. All other users should upgrade to 8.0.0.

These versions add backtrack protection when a custom regex pattern is not provided:

• 0.1.10
• 1.9.0
• 3.3.0
• 6.3.0

They do not protect against vulnerable user supplied capture groups. Protecting against explicit user patterns is out of scope for old versions and not considered a vulnerability.

Version 7.1.0 can enable strict: true and get an error when the regular expression might be bad.

Version 8.0.0 removes the features that can cause a ReDoS.

Workarounds

All versions can be patched by providing a custom regular expression for parameters after the first in a single segment. As long as the custom regular expression does not match the text before the parameter, you will be safe. For example, change /:a-:b to /:a-:b([^-/]+).

If paths cannot be rewritten and versions cannot be upgraded, another alternative is to limit the URL length. For example, halving the attack string improves performance by 4x faster.

Details

Using /:a-:b will produce the regular expression /^\/([^\/]+?)-([^\/]+?)\/?$/. This can be exploited by a path such as /a${'-a'.repeat(8_000)}/a. OWASP has a good example of why this occurs, but the TL;DR is the /a at the end ensures this route would never match but due to naive backtracking it will still attempt every combination of the :a-:b on the repeated 8,000 -a.

Because JavaScript is single threaded and regex matching runs on the main thread, poor performance will block the event loop and can lead to a DoS. In local benchmarks, exploiting the unsafe regex will result in performance that is over 1000x worse than the safe regex. In a more realistic environment using Express v4 and 10 concurrent connections, this translated to average latency of ~600ms vs 1ms.

References

• OWASP
• Detailed blog post

Release Notes

0.1.10

Fixed

• Add backtrack protection to parameters 29b96b4
  • This will break some edge cases but should improve performance

v0.1.9...v0.1.10

0.1.9

Added

• Allow a non-lookahead regex (#312) c4272e4

component/path-to-regexp@v0.1.8...v0.1.9

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:

• 0.1.10
• Add backtrack protection to parameters
• Update repo url (#314)
• 0.1.9
• Allow a non-lookahead regex (#312)
• 0.1.8
• Add support for named matching groups (#301)

↗️ proxy-addr (indirect, 1.1.5 → 2.0.7) · Repo · Changelog

Release Notes

2.0.7

• deps: [email protected]
  • Use req.socket over deprecated req.connection

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ send (indirect, 0.15.1 → 0.19.0) · Repo · Changelog

Security Advisories 🚨

🚨 send vulnerable to template injection that can lead to XSS

Impact

passing untrusted user input - even after sanitizing it - to SendStream.redirect() may execute untrusted code

Patches

this issue is patched in send 0.19.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

1. The attacker MUST control the input to response.redirect()
2. express MUST NOT redirect before the template appears
3. the browser MUST NOT complete redirection before:
4. the user MUST click on the link in the template

Release Notes

0.19.0

What's Changed

• Remove link renderization in html while redirecting (#235)

New Contributors

• @UlisesGascon made their first contribution in #235

Full Changelog: 0.18.0...0.19.0

0.18.0 (from changelog)

• Fix emitted 416 error missing headers property
• Limit the headers removed for 304 response
• deps: [email protected]
  • Replace internal eval usage with Function constructor
  • Use instance methods on process to check for listeners
• deps: [email protected]
• deps: [email protected]
  • deps: [email protected]
  • deps: [email protected]
• deps: [email protected]
• deps: [email protected]

0.17.2 (from changelog)

• pref: ignore empty http tokens
• deps: [email protected]
  • deps: [email protected]
  • deps: [email protected]
  • deps: [email protected]
• deps: [email protected]

0.17.1 (from changelog)

• Set stricter CSP header in redirect & error responses
• deps: range-parser@~1.2.1

0.17.0 (from changelog)

• deps: http-errors@~1.7.2
  • Set constructor name when possible
  • Use toidentifier module to make class names
  • deps: depd@~1.1.2
  • deps: [email protected]
  • deps: statuses@'>= 1.5.0 < 2'
• deps: [email protected]
  • Add extensions for JPEG-2000 images
  • Add new font/* types from IANA
  • Add WASM mapping
  • Update .bdoc to application/bdoc
  • Update .bmp to image/bmp
  • Update .m4a to audio/mp4
  • Update .rtf to application/rtf
  • Update .wav to audio/wav
  • Update .xml to application/xml
  • Update generic extensions to application/octet-stream: .deb, .dll, .dmg, .exe, .iso, .msi
  • Use mime-score module to resolve extension conflicts
• deps: [email protected]
  • Add week/w support
  • Fix negative number handling
• deps: statuses@~1.5.0
• perf: remove redundant path.normalize call

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ serve-static (indirect, 1.12.1 → 1.16.2) · Repo · Changelog

Security Advisories 🚨

🚨 serve-static vulnerable to template injection that can lead to XSS

Impact

passing untrusted user input - even after sanitizing it - to redirect() may execute untrusted code

Patches

this issue is patched in serve-static 1.16.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

1. The attacker MUST control the input to response.redirect()
2. express MUST NOT redirect before the template appears
3. the browser MUST NOT complete redirection before:
4. the user MUST click on the link in the template

Release Notes

1.16.0

What's Changed

• Remove link renderization in html while redirecting (#173)

New Contributors

• @UlisesGascon made their first contribution in #173

Full Changelog: v1.15.0...1.16.0

1.15.0

• deps: [email protected]
  • Fix emitted 416 error missing headers property
  • Limit the headers removed for 304 response
  • deps: [email protected]
  • deps: [email protected]
  • deps: [email protected]
  • deps: [email protected]
  • deps: [email protected]

1.14.2

• deps: [email protected]
  • deps: [email protected]
  • deps: [email protected]
  • pref: ignore empty http tokens

1.14.1 (from changelog)

• Set stricter CSP header in redirect response
• deps: [email protected]
  • deps: range-parser@~1.2.1

1.14.0

• deps: parseurl@~1.3.3
• deps: [email protected]
  • deps: http-errors@~1.7.2
  • deps: [email protected]
  • deps: [email protected]
  • deps: statuses@~1.5.0
  • perf: remove redundant path.normalize call

1.13.2

• Fix incorrect end tag in redirects
• deps: encodeurl@~1.0.2
  • Fix encoding % as last character
• deps: [email protected]
  • deps: depd@~1.1.2
  • deps: encodeurl@~1.0.2
  • deps: statuses@~1.4.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ utils-merge (indirect, 1.0.0 → 1.0.1) · Repo

Commits

See the full diff on Github. The new version differs by 13 commits:

• 1.0.1
• Add contributing guidelines.
• Update README.
• Fix make test command.
• Update support files.
• Merge pull request #4 from nooks/patch-1
• Merge pull request #3 from pdehaan/patch-1
• Add node.js versions for Travis-ci
• Update license attribute
• Update Travis CI configuration.
• Add status badges to README.
• Update Makefile.
• Update support files.

🆕 call-bind (added, 1.0.7)

🆕 define-data-property (added, 1.1.4)

🆕 es-define-property (added, 1.0.0)

🆕 es-errors (added, 1.3.0)

🆕 get-intrinsic (added, 1.2.4)

🆕 gopd (added, 1.0.1)

🆕 has-property-descriptors (added, 1.0.2)

🆕 has-proto (added, 1.0.3)

🆕 hasown (added, 2.0.2)

🆕 set-function-length (added, 1.2.2)

🆕 side-channel (added, 1.0.6)

🆕 toidentifier (added, 1.0.1)

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu cancel merge

Cancels automatic merging of this PR

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)

[depfu]

Closed in favor of #485.

[depfu]

Closed in favor of #485.