-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lts-19.24 #16
lts-19.24 #16
Conversation
ishiy1993
commented
Sep 20, 2022
•
edited
Loading
edited
- Update resolver to lts-19.24.
- Drop old resolvers in CI.
- Old stack fails to download build plan from stackage.
- https://github.com/ishiy1993/haiji/actions/runs/3087777392/jobs/4993593686
- Skip doctest for GHC 9.
- "not in scope" errors when running with GHC 9 + stack test; redux sol/doctest#327
- CI passed
- https://github.com/ishiy1993/haiji/actions/runs/3095327049
1a70bbb
to
29820a0
Compare
3549b33
to
0fe262e
Compare
55528fa
to
db24164
Compare
@notogawa Please review 🙏 (I can't request a review from Web UI in this PR.) |
@@ -7,40 +7,39 @@ jobs: | |||
build: | |||
|
|||
runs-on: ubuntu-latest | |||
continue-on-error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. If it is false
, when some LTS versions fail, other versions will be cancelled.
true
: https://github.com/ishiy1993/haiji/actions/runs/3088873538
false
: https://github.com/ishiy1993/haiji/actions/runs/3087777392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM