Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lts-19.24 #16

Merged
merged 9 commits into from
Sep 21, 2022
Merged

lts-19.24 #16

merged 9 commits into from
Sep 21, 2022

Conversation

ishiy1993
Copy link
Contributor

@ishiy1993 ishiy1993 commented Sep 20, 2022

@ishiy1993 ishiy1993 marked this pull request as ready for review September 21, 2022 05:11
@ishiy1993
Copy link
Contributor Author

@notogawa Please review 🙏 (I can't request a review from Web UI in this PR.)

@@ -7,40 +7,39 @@ jobs:
build:

runs-on: ubuntu-latest
continue-on-error: true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required?

Copy link
Contributor Author

@ishiy1993 ishiy1993 Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. If it is false, when some LTS versions fail, other versions will be cancelled.

true: https://github.com/ishiy1993/haiji/actions/runs/3088873538
false: https://github.com/ishiy1993/haiji/actions/runs/3087777392

Copy link
Owner

@notogawa notogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notogawa notogawa merged commit ecac32d into notogawa:master Sep 21, 2022
@ishiy1993 ishiy1993 deleted the update-resolver branch September 21, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants