Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust size and positioning of some diacritics #252

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MomongaFont
Copy link

Hello. Thank you for providing us with great fonts.
I'd like to submit a pull request for Noto Naskh Arabic.

The target is the following issue.
#241

image

Thank you for taking this request into consideration.

@YusukeShirakihara : Thank you very much for your significant contributions and cooperation to this pull request!

@simoncozens
Copy link
Contributor

Looks OK to me - @khaledhosny WDYT?

@khaledhosny
Copy link
Contributor

The vowel marks in Noto Naskh Arabic are indeed to small to the point of being unusable at text font sizes. So making them larger is an improvement.

Looking at the updated sources, other marks that use the adjusted ones as components need to be fixed:
fathaDotabove-ar
kasraDotbelow-ar
dammaDot-ar

Many other vowel marks need to be adjusted as well to maintain consistency, for example (may be more):
fathaHorizont-ar
fathatwodots-ar
fathaRing-ar
noonghunnaabove-ar
noonghunnaabovesideways-ar
toneloopabove-ar
leftarrowheadabove-ar
rightarrowheadabove-ar
doublerightarrowheadabove-ar
doublerightarrowheadDotabove-ar
rightarrowheadDotabove-ar
toneonedotabove-ar
tonetwodotsabove-ar
sukunoval-ar
sukunround-ar
jazm-ar
rhombusStopabove-ar
toneloopbelow-ar
leftarrowheadbelow-ar
rightarrowheadbelow-ar
toneonedotbelow-ar
tonetwodotsbelow-ar
rhombusStopbelow-ar

Interestingly, I noticed a few days ago that the original Droid Arabic Naskh had larger vowel marks, so it would be interesting to know why they were made much smaller in Noto Naskh Arabic.

Droid above, Noto from main branch below (the overall size is also smaller, I had to use 14pt for Noto to get the same size as 12pt Droid):

image

Droid above, Noto from this PR below:

image

Adjust the position of the Dot.
Adjust the position of the Dot.
Adjust the position of the Dot.
@MomongaFont
Copy link
Author

@simoncozens @khaledhosny

Thank you for reviewing this pull request. I have adjusted the three components pointed out by @khaledhosny and would appreciate your confirmation.

I'm also grateful for highlighting the vowel marks that may need adjustment to maintain consistency with the components modified in this pull request. Upon examining some of the vowel marks @khaledhosny mentioned, it appears that some were originally large and may not require adjustment. For example, vowel marks like doublerightarrowheadabove-ar and doublerightarrowheadDotabove-ar seem larger than Sukun and Fatha.
Following picture is based on Noto Naskh Arabic from this PR:
image

Considering these points, I would like to inquire about your opinion on whether this pull request can be merged at this time. Or, would you prefer that I review the vowel marks @khaledhosny mentioned, make any necessary adjustments, and submit a new pull request?

I would appreciate your feedback on this matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants