Skip to content

feat: add bdk_sqlite_store crate implementing PersistBackend backed b…

Sign in for the full log view
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy failed Sep 19, 2023 in 0s

clippy

9 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 9
Warning 0
Note 0
Help 0

Versions

  • rustc 1.67.0 (fc594f156 2023-01-24)
  • cargo 1.67.0 (8ecd4f20a 2023-01-10)
  • clippy 0.1.67 (fc594f1 2023-01-24)

Annotations

Check failure on line 31 in crates/sqlite_store/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this lifetime isn't used in the impl

error: this lifetime isn't used in the impl
  --> crates/sqlite_store/src/lib.rs:31:6
   |
31 | impl<'a> std::error::Error for AppendError {}
   |      ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes

Check failure on line 25 in crates/sqlite_store/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this lifetime isn't used in the impl

error: this lifetime isn't used in the impl
  --> crates/sqlite_store/src/lib.rs:25:6
   |
25 | impl<'a> From<serde_json::Error> for AppendError {
   |      ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes

Check failure on line 16 in crates/sqlite_store/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this lifetime isn't used in the impl

error: this lifetime isn't used in the impl
  --> crates/sqlite_store/src/lib.rs:16:6
   |
16 | impl<'a> core::fmt::Display for AppendError {
   |      ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes

Check failure on line 226 in crates/sqlite_store/src/store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

error: redundant closure
   --> crates/sqlite_store/src/store.rs:226:22
    |
226 |             .map_err(|e| AppendError::Sqlite(e))?;
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `AppendError::Sqlite`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check failure on line 196 in crates/sqlite_store/src/store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

error: redundant closure
   --> crates/sqlite_store/src/store.rs:196:30
    |
196 |                     .map_err(|e| IterError::Sqlite(e))?;
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `IterError::Sqlite`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check failure on line 175 in crates/sqlite_store/src/store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

error: redundant closure
   --> crates/sqlite_store/src/store.rs:175:62
    |
175 |                 let changeset_result = row_changeset.map_err(|e| IterError::Sqlite(e));
    |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `IterError::Sqlite`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

Check failure on line 170 in crates/sqlite_store/src/store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

error: redundant closure
   --> crates/sqlite_store/src/store.rs:170:22
    |
170 |             .map_err(|e| IterError::Sqlite(e))?;
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `IterError::Sqlite`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `-D clippy::redundant-closure` implied by `-D warnings`

Check failure on line 168 in crates/sqlite_store/src/store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)`

error: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)`
   --> crates/sqlite_store/src/store.rs:166:17
    |
166 | /                 row.get_ref(1).and_then(|r| Ok(r.as_str()?)).and_then(|j| {
167 | |                     Ok(serde_json::from_str::<C>(j).map_err(|e| IterError::Json { rowid, err: e }))
168 | |                 })
    | |__________________^ help: try this: `row.get_ref(1).and_then(|r| Ok(r.as_str()?)).map(|j| serde_json::from_str::<C>(j).map_err(|e| IterError::Json { rowid, err: e }))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
    = note: `-D clippy::bind-instead-of-map` implied by `-D warnings`

Check failure on line 46 in crates/sqlite_store/src/store.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this lifetime isn't used in the impl

error: this lifetime isn't used in the impl
  --> crates/sqlite_store/src/store.rs:46:6
   |
46 | impl<'a, C> Store<C>
   |      ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
   = note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings`