Skip to content

Commit

Permalink
Merge bitcoindevkit#1721: chore(deps): bump hashbrown to v0.14.5
Browse files Browse the repository at this point in the history
52fa540 chore(deps): bump hashbrown to v0.14.5, disable default features (Tommy Volk)

Pull request description:

  Bump [`hashbrown`](https://crates.io/crates/hashbrown) to v0.15

  I ran [`cargo build-all-features` and `cargo test-all-features`](https://github.com/frewsxcv/cargo-all-features) locally for the `core` crate with no issues. Here's the output for the former:

  ```
  cargo build-all-features

      Building crate=bdk_core features=[]
      Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
      Building crate=bdk_core features=[hashbrown]
      Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
      Building crate=bdk_core features=[serde]
      Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.05s
      Building crate=bdk_core features=[std]
      Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
      Building crate=bdk_core features=[hashbrown,serde]
      Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
      Building crate=bdk_core features=[hashbrown,std]
      Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
      Building crate=bdk_core features=[serde,std]
      Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
      Building crate=bdk_core features=[hashbrown,serde,std]
      Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
  ```

  The relevant changelog can be found between [here](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md#v0100---2021-01-16) and [here](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md#v0151---2024-11-03)

  The only notable breaking change I found was that the MSRV was bumped to v1.63. However, this is the same MSRV as we already use, so it's not a breaking change for us.

ACKs for top commit:
  notmandatory:
    ACK 52fa540

Tree-SHA512: 8281148b86c80e7e7dd32c40d1bc5081c0e772876e9db3f0e20a9748e755f541fa923ad596be3de5f1bb2d8e46ab8987196869ca445f46afa696b2c7552d829e
  • Loading branch information
notmandatory committed Nov 21, 2024
2 parents b777396 + 52fa540 commit 62e84d7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ readme = "README.md"
[dependencies]
bitcoin = { version = "0.32", default-features = false }
serde = { version = "1", optional = true, features = ["derive", "rc"] }
hashbrown = { version = "0.9.1", optional = true }
hashbrown = { version = "0.14.5", optional = true, default-features = false, features = ["ahash", "inline-more"] }

[features]
default = ["std"]
Expand Down

0 comments on commit 62e84d7

Please sign in to comment.