feat(wallet): persist and verify discriptor hashes when loading data #876
Annotations
6 errors and 5 warnings
using `clone` on type `bitcoin::bitcoin_hashes::sha256::Hash` which implements the `Copy` trait:
crates/bdk/src/wallet/mod.rs#L643
error: using `clone` on type `bitcoin::bitcoin_hashes::sha256::Hash` which implements the `Copy` trait
--> crates/bdk/src/wallet/mod.rs:643:22
|
643 | .map(|v| v.clone());
| ^^^^^^^^^ help: try dereferencing it: `*v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
you are using an explicit closure for copying elements:
crates/bdk/src/wallet/mod.rs#L640
error: you are using an explicit closure for copying elements
--> crates/bdk/src/wallet/mod.rs:640:50
|
640 | let changeset_internal_descriptor_hash = changeset
| __________________________________________________^
641 | | .descriptor_hashes
642 | | .get(&KeychainKind::Internal)
643 | | .map(|v| v.clone());
| |_______________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `-D clippy::map-clone` implied by `-D warnings`
help: consider calling the dedicated `copied` method
|
640 ~ let changeset_internal_descriptor_hash = changeset
641 + .descriptor_hashes
642 ~ .get(&KeychainKind::Internal).copied();
|
|
using `clone` on type `bitcoin::bitcoin_hashes::sha256::Hash` which implements the `Copy` trait:
crates/bdk/src/wallet/mod.rs#L619
error: using `clone` on type `bitcoin::bitcoin_hashes::sha256::Hash` which implements the `Copy` trait
--> crates/bdk/src/wallet/mod.rs:619:50
|
619 | let changeset_external_descriptor_hash = changeset
| __________________________________________________^
620 | | .descriptor_hashes
621 | | .get(&KeychainKind::External)
622 | | .ok_or(LoadError::DescriptorDoesNotMatch {
... |
626 | | })?
627 | | .clone();
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
help: try dereferencing it
|
619 ~ let changeset_external_descriptor_hash = *changeset
620 + .descriptor_hashes
621 + .get(&KeychainKind::External)
622 + .ok_or(LoadError::DescriptorDoesNotMatch {
623 + keychain: KeychainKind::External,
624 + expected: Some(external_descriptor_hash),
625 + got: None,
626 ~ })?;
|
|
using `clone` on type `bitcoin::bitcoin_hashes::sha256::Hash` which implements the `Copy` trait:
crates/bdk/src/wallet/mod.rs#L643
error: using `clone` on type `bitcoin::bitcoin_hashes::sha256::Hash` which implements the `Copy` trait
--> crates/bdk/src/wallet/mod.rs:643:22
|
643 | .map(|v| v.clone());
| ^^^^^^^^^ help: try dereferencing it: `*v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
you are using an explicit closure for copying elements:
crates/bdk/src/wallet/mod.rs#L640
error: you are using an explicit closure for copying elements
--> crates/bdk/src/wallet/mod.rs:640:50
|
640 | let changeset_internal_descriptor_hash = changeset
| __________________________________________________^
641 | | .descriptor_hashes
642 | | .get(&KeychainKind::Internal)
643 | | .map(|v| v.clone());
| |_______________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `-D clippy::map-clone` implied by `-D warnings`
help: consider calling the dedicated `copied` method
|
640 ~ let changeset_internal_descriptor_hash = changeset
641 + .descriptor_hashes
642 ~ .get(&KeychainKind::Internal).copied();
|
|
using `clone` on type `bitcoin::bitcoin_hashes::sha256::Hash` which implements the `Copy` trait:
crates/bdk/src/wallet/mod.rs#L619
error: using `clone` on type `bitcoin::bitcoin_hashes::sha256::Hash` which implements the `Copy` trait
--> crates/bdk/src/wallet/mod.rs:619:50
|
619 | let changeset_external_descriptor_hash = changeset
| __________________________________________________^
620 | | .descriptor_hashes
621 | | .get(&KeychainKind::External)
622 | | .ok_or(LoadError::DescriptorDoesNotMatch {
... |
626 | | })?
627 | | .clone();
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
help: try dereferencing it
|
619 ~ let changeset_external_descriptor_hash = *changeset
620 + .descriptor_hashes
621 + .get(&KeychainKind::External)
622 + .ok_or(LoadError::DescriptorDoesNotMatch {
623 + keychain: KeychainKind::External,
624 + expected: Some(external_descriptor_hash),
625 + got: None,
626 ~ })?;
|
|
Code Coverage
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
coverage-report
Expired
|
4.23 MB |
|