Empty submsg result does not overwrite

notional-labs · Jun 14, 2021 · 44e7669 · 44e7669
1 parent 0dd695c
commit 44e7669
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/x/wasm/keeper/msg_dispatcher.go b/x/wasm/keeper/msg_dispatcher.go
@@ -144,7 +144,7 @@ func (d MessageDispatcher) DispatchSubmessages(ctx sdk.Context, contractAddr sdk
 		switch {
 		case err != nil:
 			return nil, sdkerrors.Wrap(err, "reply")
-		case rspData != nil:
+		case len(rspData) != 0:
 			rsp = rspData
 		}
 	}

diff --git a/x/wasm/keeper/msg_dispatcher_test.go b/x/wasm/keeper/msg_dispatcher_test.go
@@ -199,7 +199,7 @@ func TestDispatchSubmessages(t *testing.T) {
 					return nil, nil, errors.New("my error")
 				},
 			},
-			expData:    []byte{},
+			expData:    []byte("myReplyData:1"),
 			expCommits: []bool{false, false},
 		},
 		"empty replyOn rejected": {