fix: sherlock-audit/2024-06-leveraged-vaults-judging#87

notional-finance · Aug 13, 2024 · 59895fb · 59895fb
1 parent 1fbc49d
commit 59895fb
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/contracts/vaults/staking/protocols/Kelp.sol b/contracts/vaults/staking/protocols/Kelp.sol
@@ -47,10 +47,13 @@ contract KelpCooldownHolder is ClonedCoolDownHolder {
     }
 
     function _finalizeCooldown() internal override returns (uint256 tokensClaimed, bool finalized) {
-        (/* */, /* */, /* */, uint256 userWithdrawalRequestNonce) = WithdrawManager.getUserWithdrawalRequest(Deployments.ALT_ETH_ADDRESS, address(this), 0);
+        (/* */, /* */, uint256 userWithdrawalStartBlock, uint256 userWithdrawalRequestNonce) = WithdrawManager.getUserWithdrawalRequest(Deployments.ALT_ETH_ADDRESS, address(this), 0);
         uint256 nextNonce = WithdrawManager.nextLockedNonce(Deployments.ALT_ETH_ADDRESS);
-        // Will revert when nextLockedNonce == userWithdrawalRequestNonce, so this must be strictly less than
-        if (nextNonce < userWithdrawalRequestNonce) {
+        // These two requirements are checked in the WithdrawManager.
+        if (
+            nextNonce < userWithdrawalRequestNonce || 
+            block.number < userWithdrawalStartBlock + WithdrawManager.withdrawalDelayBlocks()
+        ) {
             return (0, false);
         }