-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSRV 1.72 #569
MSRV 1.72 #569
Conversation
Let's merge this with #568 as 7.0 and try to get everything else into 6.X Or is there anything else that would be major breaking ? |
The change to the event serialization is already in main. And that's breaking. |
Ah yeah, my bad. Nevermind then, break all the things. |
This also needs a rebase |
`std::sync::mpsc::Sender` implements `Sync` since version 1.72, so there is no need for crossbeam anymore.
I'll re-rebase this when I'm back at home (+2days!). Then I wall have to look at the outstanding issues and PR that accumulated over the past ~2 months and push the release finally over the line.. Thanks for all the work! |
Can we merge this? I already based my next PR on this one. |
std::sync::mpsc::Sender
implementsSync
since version 1.72, so there is no need for crossbeam anymoreI screwed up a bit and this PR is based on my previous on (#567).