Add CoilImagesPlugin Module #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noties
requested changes
Nov 13, 2019
| @@ -0,0 +1,35 @@ | |||
| # Image Coil | |||
There was a problem hiding this comment.
😍 ! Very nice touch to include documentation!
docs/docs/v4/image-coil/README.md
Outdated
|
|
||
| Image loading based on `Coil` library | ||
|
|
||
| ```kt |
There was a problem hiding this comment.
Unfortunately syntax highlighting won't work for kt, please change to kotlin
| import io.noties.markwon.image.ImageSpanFactory; | ||
|
|
||
| /** | ||
| * @since 4.0.0 |
There was a problem hiding this comment.
You can put here some attribution if you wish, like your name and email, but it's optional
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166
This adds support for loading images using Coil through a new
markwon-image-coilmodule based off the implementations of the existing image plugins. I'm not too familiar with any gotchas there would be with interactions between the Markwon and Coil APIs so any guidance would be much appreciated!