Fixed kerning advance in fonts with both GPOS and kern tables. #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably, SegoeUI on Windows has kerning advances in the kern tables, but also has a GPOS table. The pair of characters aren't the same in each table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, Segoe on Windows has kerning advances in the kern tables, but also has a GPOS table. The pair of characters aren't the same in each table.
Compare the string "STB TrueType Text Renderer" in the Windows window title and the STB render inside the window:
Compare to the STB render after the fix; notice the kerning advance between "T" and "r", and "T" and "e":
(the first STB line uses Subpixel advances, the second line doesn't)