Added open() and close() functions

Web MIDI API §4.6 stipulates that output devices should have open() and close() functions. I've added these to all the synths as empty stubs. See issues #23 and #24.
notator · Dec 15, 2015 · e65aaa5 · e65aaa5
1 parent 26f4353
commit e65aaa5
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/cwMIDISynth/cwMIDISynth.js b/cwMIDISynth/cwMIDISynth.js
@@ -109,7 +109,9 @@ WebMIDI.cwMIDISynth = (function()
 			return new CWMIDISynth();
 		}
 
-		/** WebMIDIAPI §10 -- MIDIPort interface **/
+		// WebMIDIAPI §4.6 -- MIDIPort interface
+		// See https://github.com/notator/WebMIDISynthHost/issues/23
+		// and https://github.com/notator/WebMIDISynthHost/issues/24
 		Object.defineProperty(this, "id", { value: "cwMIDISynth", writable: false });
 		Object.defineProperty(this, "manufacturer", { value: "chris wilson", writable: false });
 		Object.defineProperty(this, "name", { value: "MIDI synth (Chris Wilson)", writable: false });
@@ -143,6 +145,20 @@ WebMIDI.cwMIDISynth = (function()
 		console.log("cwMIDISynth initialised.");
 	};
 
+	// WebMIDIAPI §4.6 -- MIDIPort interface
+	// See https://github.com/notator/WebMIDISynthHost/issues/24
+	CWMIDISynth.prototype.open = function()
+	{
+		console.log("cwMIDISynth opened.");
+	};
+
+	// WebMIDIAPI §4.6 -- MIDIPort interface
+	// See https://github.com/notator/WebMIDISynthHost/issues/24
+	CWMIDISynth.prototype.close = function()
+	{
+		console.log("cwMIDISynth closed.");
+	};
+
 	// WebMIDIAPI MIDIOutput send()
 	// This synth does not support timestamps
 	CWMIDISynth.prototype.send = function(message, ignoredTimestamp)

diff --git a/sf2Synth1/sf2Synth1.js b/sf2Synth1/sf2Synth1.js
@@ -108,7 +108,9 @@ WebMIDI.sf2Synth1 = (function(window)
 			return new Sf2Synth1();
 		}
 
-		/** WebMIDIAPI §10 -- MIDIPort interface **/
+		// WebMIDIAPI §4.6 -- MIDIPort interface
+		// See https://github.com/notator/WebMIDISynthHost/issues/23
+		// and https://github.com/notator/WebMIDISynthHost/issues/24
 		Object.defineProperty(this, "id", { value: "Sf2Synth01", writable: false });
 		Object.defineProperty(this, "manufacturer", { value: "gree & ji", writable: false });
 		Object.defineProperty(this, "name", { value: "Sf2Synth1 (gree & ji)", writable: false });
@@ -169,6 +171,20 @@ WebMIDI.sf2Synth1 = (function(window)
     };
 	// end var
 
+	// WebMIDIAPI §4.6 -- MIDIPort interface
+	// See https://github.com/notator/WebMIDISynthHost/issues/24
+	Sf2Synth1.prototype.open = function()
+	{
+		console.log("sf2Synth1 opened.");
+	};
+
+	// WebMIDIAPI §4.6 -- MIDIPort interface
+	// See https://github.com/notator/WebMIDISynthHost/issues/24
+	Sf2Synth1.prototype.close = function()
+	{
+		console.log("sf2Synth1 closed.");
+	};
+
 	// WebMIDIAPI MIDIOutput send()
 	// This synth does not yet support timestamps (05.11.2015)
 	Sf2Synth1.prototype.send = function(message, ignoredTimestamp)