Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scenario for tag to digest mapping #48

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

sudo-bmitch
Copy link
Contributor

This covers the scenario where a tag could be modified to point to a vulnerable but previously signed digest. Example attacks I can think of:

  • Change x-scratch to point to the digest used by x-alpine to include a shell that may expose vulnerabilities.
  • If v3 is updated after a CVE is discovered, an attacker could roll back the tag to point to the vulnerable digest.

The end goal is when users pull image:tag, the returned digest can be verified as one the image signer has currently approved for tag. By including this use case, we also cover the use case supported by Notary v1.

Signed-off-by: Brandon Mitchell [email protected]

Signed-off-by: Brandon Mitchell <[email protected]>
scenarios.md Outdated Show resolved Hide resolved
@dlorenc
Copy link

dlorenc commented Mar 21, 2021

Maybe a more accurate name for this would be "signing a tag-> digest mapping"? It sounds like you're not proposing we sign tags themselves, but rather the mapping of a tag to a digest at a particular moment in time.

@sudo-bmitch sudo-bmitch changed the title Adding scenario for tag signing Adding scenario for tag to digest mapping Mar 22, 2021
@dlorenc
Copy link

dlorenc commented Mar 22, 2021

Thanks!

@SteveLasker
Copy link
Contributor

This is goodness as it captures the root problem of tag rollbacks, without implying the solution.
It also doesn't suggest the older digest is invalid. It just implies we need a solution that says tag:v1 that updated from digest:a to digest:b must accurately reflect the current digest of tag:v1

@SteveLasker SteveLasker merged commit d04c49c into notaryproject:main Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants