Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: support short name S for state/province #307

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Jul 30, 2024

Resolve #287

Signed-off-by: Yi Zha [email protected]

@yizha1
Copy link
Contributor Author

yizha1 commented Jul 30, 2024

@priteshbandi @shizhMSFT @Two-Hearts @JeyJeyGao Would you mind taking a look at this PR?

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this PR cover #293 and #298?

@yizha1
Copy link
Contributor Author

yizha1 commented Jul 30, 2024

@shizhMSFT no, only fixing 287 to support additional S.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is better to have a reference where S and ST come from.

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi
Copy link
Contributor

priteshbandi commented Aug 2, 2024

Can you please open an issue in notation-go to implement this?

@yizha1 yizha1 merged commit 00abcea into notaryproject:main Aug 2, 2024
1 check passed
@yizha1 yizha1 deleted the fix-issue287 branch August 2, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support x509 subject with RDN state/province using short name "S"
5 participants