doc: notation supports OCI Image manifest #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Zha <[email protected]>
yizha1
requested review from
toddysm,
priteshbandi,
shizhMSFT,
FeynmanZhou,
iamsamirzon and
vaninrao10
shizhMSFT
reviewed
Jan 6, 2023
Signed-off-by: Yi Zha <[email protected]>
shizhMSFT
reviewed
Jan 8, 2023
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
patrickzheng200
suggested changes
Jan 10, 2023
Signed-off-by: Yi Zha <[email protected]>
specs/signature-specification.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Besides the [image manifest property requirements][image-manifest-property-descriptions], the properties has the following additional restrictions: |
There was a problem hiding this comment.
Suggested change
| Besides the [image manifest property requirements][image-manifest-property-descriptions], the properties has the following additional restrictions: | |
| Besides the [image manifest property requirements][image-manifest-property-descriptions], the property has the following additional restrictions: |
There was a problem hiding this comment.
I would like to keep the plural and changed the word has to have.
Signed-off-by: Yi Zha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
Signed-off-by: Yi Zha [email protected]