-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenario updates, incorporating scenarios, addressing PR feedback #15
Conversation
Signed-off-by: Steve Lasker <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
Can we get some 👀 on this so we can close these out? |
@JustinCappos, can you ack that we've captured the scenarios portion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document is really design heavy now. This covers a few cases but things like 7 only make sense in the context of a specific design, whereas 8 and 9 are much more general.
Are you referring to the scenario or implications? Do you have a proposed edit so we can merge? |
It's more of a conceptual change to parts of the document. Some of the content like this feels like it is quite specific to the technologies and not the goals / scenarios. I'm just going to cut and paste a few example, but the conceptual difference is something I'm seeing throughout. "The ACME Rockets environment enforces various company policies prior to any deployment, evaluating the content in the
"The local environment has a policy by which it states the set of keys it accepts.
"Users may reference the I don't really know if this should be moved to a separate document, if general text should replace it, or if I'm just keying in on things that I shouldn't. Perhaps @justincormack should weigh in also and say whether what I'm objecting to makes any sense. |
@JustinCappos I think we're possibly seeing a view from different perspectives. There's a perspective that we need a signature solution to artifacts in a registry. A solution that can move with the artifact as it moves within and across registries. That does define a sandbox by which we're working within. In the call last week we discussed how we may need to tweak the sandbox, but we are scoping to storing signatures in a registry. |
1. The developer revokes their public key, indicating it's no longer valid. | ||
1. The developer issues a new public key and re-signs their content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgive me if this is covered elsewhere, I'm quite new here -- what are the implications, and verifications, needed for this new key authenticity? I don't see it in the implications below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving this open to see if we cover this in the key management working group.
Signed-off-by: Steve Lasker <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tsaarni, great feedback I've incorporated into the latest update.
1. The developer revokes their public key, indicating it's no longer valid. | ||
1. The developer issues a new public key and re-signs their content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving this open to see if we cover this in the key management working group.
Signed-off-by: Steve Lasker <[email protected]>
Signed-off-by: Steve Lasker <[email protected]>
…taryproject#15) Merging to have a base to iterate upon: * Scenario updates, incorporating scenarios from @JustinCappos * Spelling fix * updated scenarios for multiple keys, added requirements * Address PR feedback * Fix typos Signed-off-by: Steve Lasker <[email protected]>
…taryproject#15) Merging to have a base to iterate upon: * Scenario updates, incorporating scenarios from @JustinCappos * Spelling fix * updated scenarios for multiple keys, added requirements * Address PR feedback * Fix typos Signed-off-by: Steve Lasker <[email protected]>
Incorporates feedback from #12
Signed-off-by: Steve Lasker [email protected]