Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the issue with getting credentials for docker.io #703

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

Wwwsylvia
Copy link
Contributor

Fixes #697

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/notation/login.go Show resolved Hide resolved
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 651412a into notaryproject:main Jun 6, 2023
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
@Wwwsylvia Wwwsylvia deleted the fix_docker_io branch October 16, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notation login fails to detect existing credentials for docker.io
4 participants