Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quick start in readme file #428

Merged
merged 20 commits into from
Nov 3, 2022
Merged

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Nov 3, 2022

What

  1. hello-signing.md is deprecated. Use quick start https://notaryproject.dev/docs/quickstart/
  2. Missing "creating trust policy file" in the steps of Notation Quick Start section. However, it is not easy to add it since we don't have a command to do it. Remove the whole section of Notation Quick Start` for now. User can follow the quick start document link to try notation. We can add it back when we simplify the trust policy UX.

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to remove duplicate content from source code repo.

@codecov-commenter
Copy link

Codecov Report

Merging #428 (af3cc04) into main (965a0b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   32.95%   32.95%           
=======================================
  Files          25       25           
  Lines        1232     1232           
=======================================
  Hits          406      406           
  Misses        814      814           
  Partials       12       12           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@FeynmanZhou
Copy link
Member

@yizha1 I think we might also need to remove this document as it should also be included in the Notary website only.

@yizha1 yizha1 requested a review from FeynmanZhou November 3, 2022 06:34
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtzar dtzar merged commit 9270ca0 into notaryproject:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants