Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message for dangling reference index #402

Merged

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented May 11, 2024

Test example:

notation sign docker.io/xxx/hello:v1 --plugin azure-kv --id https://xxx.vault.azure.net/certificates/xxx/xxx --plugin-config credential_type=azurecli -v
INFO The referrers tag schema is always attempted 
INFO Reference v1 resolved to manifest descriptor: {MediaType:application/vnd.docker.distribution.manifest.v2+json Digest:sha256:f54a58bc1aac5ea1a25d796ae155dc228b3f0e11d046ae276b39c4bf2f13d8c4 Size:525 URLs:[] Annotations:map[] Data:[] Platform:<nil> ArtifactType:} 
Warning: Always sign the artifact using digest(@sha256:...) rather than a tag(:v1) because tags are mutable and a tag reference can point to a different artifact than the one signed.
Warning: Removal of outdated referrers index from remote registry failed. Garbage collection may be required.
Successfully signed docker.io/mxd950630/hello@sha256:f54a58bc1aac5ea1a25d796ae155dc228b3f0e11d046ae276b39c4bf2f13d8c4

Resolves #400
Signed-off-by: Junjie Gao [email protected]

@JeyJeyGao JeyJeyGao marked this pull request as ready for review May 11, 2024 08:46
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (9ff1891) to head (a42ab40).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   73.43%   80.17%   +6.74%     
==========================================
  Files          24       31       +7     
  Lines        2507     2174     -333     
==========================================
- Hits         1841     1743      -98     
+ Misses        526      302     -224     
+ Partials      140      129      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

notation.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao force-pushed the fix/dangling_referrer_error_message branch from d34d814 to 269845c Compare May 11, 2024 09:04
JeyJeyGao added 10 commits May 11, 2024 17:05
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, this PR depends on PR #405.

@JeyJeyGao JeyJeyGao requested a review from Two-Hearts May 29, 2024 00:28
notation.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao added 2 commits May 29, 2024 10:11
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao requested a review from Two-Hearts May 29, 2024 02:18
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit b7fde51 into notaryproject:main May 29, 2024
9 checks passed
This was referenced May 29, 2024
@Two-Hearts Two-Hearts mentioned this pull request Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push successful but logged an error
3 participants