Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JWS conformance test #57

Merged

Conversation

JeyJeyGao
Copy link
Contributor

Test the conformance between signed message and original signing request.

Signed-off-by: Junjie Gao [email protected]

Copy link
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall

@JeyJeyGao JeyJeyGao force-pushed the junjiegao/jws_optimize branch from 733ba12 to e651038 Compare August 29, 2022 06:16
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao JeyJeyGao force-pushed the junjiegao/jws_optimize branch from e651038 to 33177be Compare August 29, 2022 08:18
Copy link

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickzheng200 patrickzheng200 merged commit 80a50e6 into notaryproject:cose Aug 29, 2022
JeyJeyGao added a commit to JeyJeyGao/notation-core-go that referenced this pull request Sep 13, 2022
Signed-off-by: Junjie Gao <[email protected]>

Signed-off-by: Junjie Gao <[email protected]>
Co-authored-by: Junjie Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants