Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add signature documents #39

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Conversation

binbin-li
Copy link
Contributor

What?

Add docs to signature module.

Signed-off-by: Binbin Li [email protected]

@binbin-li binbin-li force-pushed the signature-doc branch 5 times, most recently from a82c1ef to b65d6b6 Compare August 17, 2022 08:39
signature/envelope.go Outdated Show resolved Hide resolved
signature/envelope.go Outdated Show resolved Hide resolved
signature/envelope.go Outdated Show resolved Hide resolved
signature/types.go Outdated Show resolved Hide resolved
Copy link
Contributor

@chloeyin chloeyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Binbin Li <[email protected]>
@binbin-li binbin-li merged commit 8aef2e4 into notaryproject:cose Aug 19, 2022
JeyJeyGao pushed a commit to JeyJeyGao/notation-core-go that referenced this pull request Sep 13, 2022
* doc: add signature documents

Signed-off-by: Binbin Li <[email protected]>

* doc: refactor comments

Signed-off-by: Binbin Li <[email protected]>

Signed-off-by: Binbin Li <[email protected]>
Co-authored-by: Binbin Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants