-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add signature documents #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binbin-li
force-pushed
the
signature-doc
branch
5 times, most recently
from
August 17, 2022 08:39
a82c1ef
to
b65d6b6
Compare
Signed-off-by: Binbin Li <[email protected]>
binbin-li
force-pushed
the
signature-doc
branch
from
August 19, 2022 02:30
b65d6b6
to
c05f579
Compare
chloeyin
reviewed
Aug 19, 2022
chloeyin
reviewed
Aug 19, 2022
chloeyin
reviewed
Aug 19, 2022
chloeyin
reviewed
Aug 19, 2022
chloeyin
reviewed
Aug 19, 2022
chloeyin
reviewed
Aug 19, 2022
chloeyin
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Binbin Li <[email protected]>
binbin-li
force-pushed
the
signature-doc
branch
from
August 19, 2022 02:59
89d898e
to
a845b8b
Compare
JeyJeyGao
pushed a commit
to JeyJeyGao/notation-core-go
that referenced
this pull request
Sep 13, 2022
* doc: add signature documents Signed-off-by: Binbin Li <[email protected]> * doc: refactor comments Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Binbin Li <[email protected]> Co-authored-by: Binbin Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add docs to signature module.
Signed-off-by: Binbin Li [email protected]