updated COSE envelope implementation per code review #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
chloeyin
reviewed
Aug 12, 2022
Signed-off-by: Patrick Zheng <[email protected]>
binbin-li
reviewed
Aug 12, 2022
chloeyin
reviewed
Aug 15, 2022
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
pushed a commit
to JeyJeyGao/notation-core-go
that referenced
this pull request
Sep 13, 2022
* updated COSE envelope implementation per code reivew Signed-off-by: Patrick Zheng <[email protected]> * renamed to envelope under cose package Signed-off-by: Patrick Zheng <[email protected]> * update per code review Signed-off-by: Patrick Zheng <[email protected]> * updated per code review Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> * more clean up Signed-off-by: Patrick Zheng <[email protected]> * updated errors according to errors.go Signed-off-by: Patrick Zheng <[email protected]> * clean up Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with envelope_test.go
Signed-off-by: Patrick Zheng [email protected]